Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 17, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

A couple things I missed in my previous nightly build PR:

  1. The version was not passed to lerna version correctl. As a result, lerna tried to create the wrong version.
  2. The nightly build branch was not created. As a result, lerna tried to push to the wrong branch.

What is the new behavior?

  • A nightly branch is now created on run and then cleaned up after the version is created
  • The correct nightly version is passed to lerna version

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi marked this pull request as ready for review November 17, 2022 14:55
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 17, 2022 14:55
@liamdebeasi liamdebeasi merged commit a52bfe6 into main Nov 17, 2022
@liamdebeasi liamdebeasi deleted the nightly-cleanup branch November 17, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants