chore(popover): ionMount is only emitted for lazy build #26303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * ionMount only needs to be emitted if the popover is inline. | ||
| */ | ||
| this.ionMount.emit(); | ||
| if (lazyBuild) { |
Contributor
There was a problem hiding this comment.
The tech debt ticket also mentions wrapping the await waitOneFrame (below the ionMount emit) in this check; was that skipped intentionally?
Contributor
Author
|
Closing this PR as it was discovered that the linked issue to this PR: #26306 requires this infrastructure, which applies to CE builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ionMountis emitted for CE build and lazy build.Issue URL: Internal
What is the new behavior?
ionMountis only emitted for the lazy build (is only needed in Angular due to the conditionally mounting the overlay content with Angular templates).Does this introduce a breaking change?
Other information