Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 14, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25367

What is the new behavior?

  • Changing the value of ion-segment now centers the active ion-segment-button. This includes bringing out of bounds buttons into bounds.
  • I modeled this change after the Google Play Store segment control which centers each button (as much as possible):
screen-20221114-155638.mp4

Note: I was unable to create a stable Playwright test for this. Even when using waitForElementState('stable') the tests were flaky. Open to ideas!

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 14, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 14, 2022 21:27
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 14, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: automatically bring to focus ion-segment-button when clicked in scrollable segment

3 participants