Skip to content

fix(popover): popover positioning for controller and inline #26274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2022
Merged

fix(popover): popover positioning for controller and inline #26274

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ffdd3
fix(popover): popover positioning for controller and inline
sean-perkins Nov 11, 2022
5efcadc
Merge branch 'main' into fix/popover-positioning
sean-perkins Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions core/src/components/popover/popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,18 +465,16 @@ export class Popover implements ComponentInterface, PopoverInterface {
this.configureDismissInteraction();

// TODO: FW-2773: Apply this to only the lazy build.
if (inline === true) {
/**
* ionMount only needs to be emitted if the popover is inline.
*/
this.ionMount.emit();
/**
* Wait one raf before presenting the popover.
* This allows the lazy build enough time to
* calculate the popover dimensions for the animation.
*/
await waitOneFrame();
}
/**
* ionMount only needs to be emitted if the popover is inline.
*/
this.ionMount.emit();
/**
* Wait one raf before presenting the popover.
* This allows the lazy build enough time to
* calculate the popover dimensions for the animation.
*/
await waitOneFrame();

this.currentTransition = present(this, 'popoverEnter', iosEnterAnimation, mdEnterAnimation, {
event: event || this.event,
Expand Down