Skip to content

Conversation

@averyjohnston
Copy link
Contributor

@averyjohnston averyjohnston commented Nov 10, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Removes a bunch of TODOs that were added a long time ago, don't seem necessary anymore, and/or have no context. Some are also likely to be handled in other tickets, such as notes to add types when we have FW-2690.
  • Adds tech debt tickets to TODOs that were missing them and seem useful to keep around.

Let me know if any of these should be kept and if you have context I could add when creating a ticket.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Nov 10, 2022
@averyjohnston averyjohnston marked this pull request as ready for review November 10, 2022 22:10
@averyjohnston averyjohnston requested a review from a team as a code owner November 10, 2022 22:10
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise this looks good. Thanks for doing this!

@averyjohnston averyjohnston merged commit e3ef932 into main Nov 14, 2022
@averyjohnston averyjohnston deleted the todo-updates branch November 14, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants