Skip to content

fix(react): inline overlays display contents consistently #26255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2022
Merged

fix(react): inline overlays display contents consistently #26255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b586b32
fix(react): inline overlays display contents consistently
sean-perkins Nov 9, 2022
8cdc1ad
test(react): inline overlay contents are visible when presented
sean-perkins Nov 9, 2022
d5c7dbd
Merge branch 'main' into FW-2778
sean-perkins Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react/src/components/createInlineOverlayComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export const createInlineOverlayComponent = <PropType, ElementType>(
{
id: 'ion-react-wrapper',
ref: this.wrapperRef,
className: 'ion-delegate-host',
style: {
display: 'flex',
flexDirection: 'column',
Expand Down
19 changes: 19 additions & 0 deletions packages/react/test-app/tests/e2e/specs/overlay-components/KeepContentsMounted.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,25 @@ describe('keepContentsMounted', () => {

cy.get('ion-modal ion-content').should('exist');
});

it('should display contents consistently on re-open', () => {
// https://github.com/ionic-team/ionic-framework/issues/26253
cy.visit('/keep-contents-mounted');

cy.get('#open-modal').click();

cy.get('ion-modal ion-content').should('exist');

cy.get('ion-modal ion-button').click();

cy.get('ion-modal')
.should('not.be.visible')
.should('have.class', 'overlay-hidden');

cy.get('#open-modal').click();

cy.get('ion-modal ion-button').should('be.visible');
})
})
describe('popover', () => {
it('should not mount component if false', () => {
Expand Down