Skip to content

Conversation

@matiassalles99
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Button gets different padding values on different platforms

Issue URL: #23928

What is the new behavior?

Introduce consistency across platforms for padding on button

Does this introduce a breaking change?

  • Yes
  • No

@matiassalles99 matiassalles99 requested a review from a team as a code owner November 2, 2022 20:14
@github-actions github-actions bot added the package: core @ionic/core package label Nov 2, 2022
@liamdebeasi liamdebeasi changed the title fix(button): Add padding to normalize css for buttons fix(normalize): normalize css resets button padding Nov 18, 2022
@liamdebeasi liamdebeasi merged commit e14c947 into ionic-team:main Nov 18, 2022
@liamdebeasi
Copy link
Contributor

Merged. Thank you very much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants