-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat(datetime-button): add support for opening datetimes in overlays with button #25649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit c6e594b.
When using the mutation observer I needed three |
I'm good with the internal event pattern then 👍 For the width changes in the grid, I would recommend we set a min width/styles to make the month/year selection match the same width as the date picker. Having the layout not shift when toggling between would be ideal here. |
I'm also okay with the |
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
I found a better way to fix the sizing of the datetime in a less intrusive way. (See latest commits) |
Observing that the lower bounds for the min-width is causing clipping in the overlay test (with popover): Also, likely unrelated to any of these changes, but there is some odd rendering happening at the bottom of the picker columns in iOS emulation: It looks like the top few pixels of text of the columns are rendering above the border that separates the picker column and the actions. |
Good catch. The usage in one of the tests was incorrect, resulting in the size/positioning being wrong.
I can repro in |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Internal ticket
What is the new behavior?
Does this introduce a breaking change?
Other information
Note: The modal + datetime tests will not work until #25648 is merged in