-
Notifications
You must be signed in to change notification settings - Fork 13.5k
fix(datetime-button): handle preferWheel correctly #25621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c6e594b.
sean-perkins
approved these changes
Jul 12, 2022
averyjohnston
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The datetime button feature currently renders separate date and time buttons for
presentation="date-time"
regardless ofprefer-wheel
. That is because this feature was built beforeprefer-wheel
was even thought of.As a result, given
<ion-datetime presentation="date-time" prefer-wheel="true">
, the datetime button will render:While this technically works, it is likely not what users are expecting. When used inline, the datetime displays as a single wheel picker with both date and time in the same wheel picker.
Additionally, this UI lets users select an explicit year which is out of scope for the combined date+time picker.
What is the new behavior?
Does this introduce a breaking change?
Other information
Note: You may encounter some weird date selections with the combined date+time picker. I believe this is related to the overlays not being sized correctly and will address in a separate PR.