Skip to content

feat(datetime-button): add base styles and examples #25618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 14, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jul 12, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: Internal ticket.

What is the new behavior?

  • Added sample index.html files. Not all of them are fully functional as this PR is mainly responsible for laying the groundwork for future PRs.
  • Added the base styling for datetime-button
  • Extracted the presentation types to a new DatetimePresentation type

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jul 12, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review July 12, 2022 16:19
@liamdebeasi liamdebeasi requested a review from a team July 12, 2022 16:19
@@ -12,6 +14,11 @@ import type { Color } from '../../interface';
shadow: true,
})
export class DatetimeButton implements ComponentInterface {
// STUBs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions in this area:

  1. What does the // STUBs comment signify?
  2. Do these state values get set to undefined at some point in execution/configuration?
  3. Should these variables have default values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"stub" means that the values are placeholders. It allows me to focus on getting the styles working first without having to worry about implementation details. The implementation is here: #25620 (note that the stubs are removed and replaced with actual values)

Base automatically changed from 546-base to FW-546 July 14, 2022 14:00
@liamdebeasi liamdebeasi merged commit 6e1daaa into FW-546 Jul 14, 2022
@liamdebeasi liamdebeasi deleted the 546-styles branch July 14, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants