-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat(datetime-button): add base styles and examples #25618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -12,6 +14,11 @@ import type { Color } from '../../interface'; | |||
shadow: true, | |||
}) | |||
export class DatetimeButton implements ComponentInterface { | |||
// STUBs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions in this area:
- What does the
// STUBs
comment signify? - Do these state values get set to
undefined
at some point in execution/configuration? - Should these variables have default values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"stub" means that the values are placeholders. It allows me to focus on getting the styles working first without having to worry about implementation details. The implementation is here: #25620 (note that the stubs are removed and replaced with actual values)
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Internal ticket.
What is the new behavior?
DatetimePresentation
typeDoes this introduce a breaking change?
Other information