Skip to content

fix(react-router): enable swipe-back animation for React iOS #25469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

masonicboom
Copy link
Contributor

@masonicboom masonicboom commented Jun 14, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Swipe back on iOS immediately triggers back navigation, rather than showing a native-like transition.

Issue URL: #22342

What is the new behavior?

Swipe-back in ios mode performs a smooth swipe transition animation, then triggers back navigation at the end of the transition (if the swipe went far enough).

Does this introduce a breaking change?

  • Yes
  • No

Other information

Before
https://user-images.githubusercontent.com/86958/173904217-85692fae-fafd-413d-8ab7-74fee2ba80c8.mov

After
https://user-images.githubusercontent.com/86958/173903656-b3ceeb1f-4d38-4213-b3cf-d1f137dd9339.mov

@masonicboom masonicboom requested a review from a team June 14, 2022 23:21
@github-actions github-actions bot added the package: react @ionic/react package label Jun 14, 2022
@masonicboom masonicboom marked this pull request as draft June 14, 2022 23:21
@masonicboom masonicboom changed the title [WIP] swipe-back animation for React iOS fix: enable swipe-back animation for React iOS Jun 15, 2022
@masonicboom masonicboom marked this pull request as ready for review June 15, 2022 19:01
@masonicboom masonicboom force-pushed the ios-react-swipe-back branch from 032bacd to 14ba118 Compare June 15, 2022 19:01
@masonicboom masonicboom changed the title fix: enable swipe-back animation for React iOS fix(react-router): enable swipe-back animation for React iOS Jun 15, 2022
@liamdebeasi
Copy link
Contributor

Hey there,

Thanks for the PR! We really appreciate all the hard work you put into creating this. I put up a new PR in #25563 that is a combination of your work and my work. I also added some tests so this behavior does not regress.

I am going to close this in favor of the new PR, but I will be sure to give you co-author credit if the PR merges. Also, there is a dev build in #22342 (comment) if you are interested in testing this fix out in your apps. Thanks again!

@masonicboom
Copy link
Contributor Author

Hey there,

Thanks for the PR! We really appreciate all the hard work you put into creating this. I put up a new PR in #25563 that is a combination of your work and my work. I also added some tests so this behavior does not regress.

I am going to close this in favor of the new PR, but I will be sure to give you co-author credit if the PR merges. Also, there is a dev build in #22342 (comment) if you are interested in testing this fix out in your apps. Thanks again!

Awesome! Thanks for taking it to the finish line. I'll test out your build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants