-
Notifications
You must be signed in to change notification settings - Fork 13.5k
fix(react-router): enable swipe-back animation for React iOS #25469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
032bacd
to
14ba118
Compare
Hey there, Thanks for the PR! We really appreciate all the hard work you put into creating this. I put up a new PR in #25563 that is a combination of your work and my work. I also added some tests so this behavior does not regress. I am going to close this in favor of the new PR, but I will be sure to give you co-author credit if the PR merges. Also, there is a dev build in #22342 (comment) if you are interested in testing this fix out in your apps. Thanks again! |
Awesome! Thanks for taking it to the finish line. I'll test out your build. |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Swipe back on iOS immediately triggers back navigation, rather than showing a native-like transition.
Issue URL: #22342
What is the new behavior?
Swipe-back in
ios
mode performs a smooth swipe transition animation, then triggers back navigation at the end of the transition (if the swipe went far enough).Does this introduce a breaking change?
Other information
Before
https://user-images.githubusercontent.com/86958/173904217-85692fae-fafd-413d-8ab7-74fee2ba80c8.mov
After
https://user-images.githubusercontent.com/86958/173903656-b3ceeb1f-4d38-4213-b3cf-d1f137dd9339.mov