-
Notifications
You must be signed in to change notification settings - Fork 13.5k
test(datetime): migrate tests to playwright #25400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think you'll need to set the values to be something in May or sooner, so the datetimes show that month instead of the current one. Otherwise, the circle around today's date will change from day to day and cause screenshot mismatches. |
Fixed, thanks! |
Looks like some of the screenshots are still showing June, |
Ok now it should be good. When I re-ran screenshots, I did not delete the old screenshots first. There may not have been a high enough pixel difference for certain screenshots causing them to not get updated. |
The screenshots for the footer tests are still showing June; maybe the screenshot job isn't looking at the right commit? 🤔 There might be other tests like that, I haven't looked. |
🤦 I only deleted screenshots for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👍
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A
What is the new behavior?
datetimeMonthDidChange
event is now dispatched on the window instead of the document. Our customspyOnEvent
only listens on the window at the moment. The effort to update this does not seem worth it at the moment.Does this introduce a breaking change?
Other information