Skip to content

fix(loading): spinner now respects —spinner-color #25261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 12, 2022
Merged
7 changes: 1 addition & 6 deletions core/src/components/loading/loading.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,6 @@
z-index: $z-index-overlay-wrapper;
}

.spinner-lines,
.spinner-lines-small,
.spinner-bubbles,
.spinner-circles,
.spinner-crescent,
.spinner-dots {
ion-spinner {
color: var(--spinner-color);
}
8 changes: 4 additions & 4 deletions core/src/components/loading/test/basic/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<ion-button
id="custom-class-loading"
expand="block"
onclick="openLoading({duration: 5000,message: 'Please wait...', cssClass: 'custom-class custom-loading'})"
onclick="openLoading({duration: 5000,message: 'Please wait...', spinner: 'lines-sharp', cssClass: 'custom-class custom-loading'})"
>Show Loading with cssClass</ion-button
>
<ion-button id="backdrop-loading" expand="block" onclick="openLoading({backdropDismiss: true})"
Expand Down Expand Up @@ -112,15 +112,15 @@
}

.custom-loading {
--background: rgba(37, 210, 223, 0.8);
--spinner-color: white;
--background: rgba(255, 255, 255, 0.8);
--spinner-color: #ea445a;

--height: 100%;
--max-height: auto;
--width: 100%;
--max-width: auto;

color: white;
color: #3478f6;
}

f {
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/loading/test/basic/loading.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ test.describe('loading: basic', () => {
await runVisualTest(page, '#translucent-loading', 'translucent');
});
test('should open a loader with a custom class', async ({ page }) => {
await runVisualTest(page, '#no-spinner-loading', 'no-spinner');
await runVisualTest(page, '#custom-class-loading', 'custom-class');
});
test('should open a loader with html content', async ({ page }) => {
await runVisualTest(page, '#html-content-loading', 'html-content');
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.