Skip to content

test(modal): remove redundant header swipe test #25207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022
Merged

test(modal): remove redundant header swipe test #25207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions core/src/components/modal/test/card-scroll-target/modal.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,6 @@ test.describe('card modal - scroll target', () => {
await page.goto('/src/components/modal/test/card-scroll-target');
});
test.describe('card modal: swipe to close', () => {
test('it should swipe to close when swiped on the header', async ({ page }) => {
const ionModalDidPresent = await page.spyOnEvent('ionModalDidPresent');
const ionModalDidDismiss = await page.spyOnEvent('ionModalDidDismiss');

await page.click('#card');
await ionModalDidPresent.next();

const header = await page.locator('ion-modal ion-header');
await dragElementBy(header, page, 0, 500);

await ionModalDidDismiss.next();
});
test('it should swipe to close when swiped on the content', async ({ page }) => {
const ionModalDidPresent = await page.spyOnEvent('ionModalDidPresent');
const ionModalDidDismiss = await page.spyOnEvent('ionModalDidDismiss');
Expand Down