Skip to content

chore(): update release scripts #25203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2022
Merged

chore(): update release scripts #25203

merged 3 commits into from
Apr 29, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

After #25195 I realized that the package-lock.json files for dependencies were not being updated during the release process. For example:

  • The version of the package-lock for @ionic/vue was bumped to ^6.1.3
  • However, that package-lock has a reference to @ionic/core that still stays on ^6.1.2
  • There is no impact to what version gets installed because of the caret (^), but the next time CI runs npm install, the package lock file will get bumped to v6.1.3 and will fail due to the changes in fix(vue): canDismiss definition is now exposed #25195.

What is the new behavior?

  • This PR ensures that the release script updates the versions for Ionic dependencies during the release process.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team April 27, 2022 14:47
@liamdebeasi liamdebeasi merged commit 2fbd621 into main Apr 29, 2022
@liamdebeasi liamdebeasi deleted the release-package-lock branch April 29, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants