Skip to content

fix(vue): canDismiss definition is now exposed #25195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Install Angular Server Dependencies
run: npm install --legacy-peer-deps
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/actions/build-angular/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand All @@ -27,7 +27,7 @@ runs:
path: ./core
filename: CoreBuild.zip
- name: Install Angular Dependencies
run: npm install
run: npm install --legacy-peer-deps
shell: bash
working-directory: ./angular
- name: Link @ionic/core
Expand All @@ -46,6 +46,10 @@ runs:
run: npm run build
shell: bash
working-directory: ./angular
- name: Check Diff
run: git diff --exit-code
shell: bash
working-directory: ./angular
- uses: ./.github/workflows/actions/upload-archive
with:
name: ionic-angular
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/build-core/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
ref: ${{ github.event.pull_request.head.sha }}
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Node Modules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/build-react-router/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/actions/build-react/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down Expand Up @@ -39,6 +39,10 @@ runs:
run: npm run test.spec
shell: bash
working-directory: ./packages/react
- name: Check Diff
run: git diff --exit-code
shell: bash
working-directory: ./packages/react
- uses: ./.github/workflows/actions/upload-archive
with:
name: ionic-react
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/build-vue-router/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/actions/build-vue/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down Expand Up @@ -35,6 +35,10 @@ runs:
run: npm run build
shell: bash
working-directory: ./packages/vue
- name: Check Diff
run: git diff --exit-code
shell: bash
working-directory: ./packages/vue
- uses: ./.github/workflows/actions/upload-archive
with:
name: ionic-vue
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- uses: ./.github/workflows/actions/download-archive
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/test-core-e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/test-core-lint/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/test-core-spec/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/test-react-e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/actions/test-vue-e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x

- name: Cache Core Node Modules
uses: actions/cache@v2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 16.x
- uses: actions/download-artifact@v2
with:
path: ./artifacts
Expand Down
32 changes: 16 additions & 16 deletions angular/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 16 additions & 16 deletions packages/react/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 16 additions & 16 deletions packages/vue/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading