Skip to content

test(picker-internal): screenshot and a11y (axe) #25150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Apr 27, 2022
Merged

test(picker-internal): screenshot and a11y (axe) #25150

merged 35 commits into from
Apr 27, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Test migration

What is the current behavior?

ion-picker-internal e2e tests are written with puppeteer.

What is the new behavior?

  • Added @axe-core/playwright for a11y testing
  • Screenshot tests for ion-picker-internal usages

Does this introduce a breaking change?

  • Yes
  • No

Other information

Opted for testing AXE violations with:

expect(results.violations).toEqual([]);

instead of:

expect(results.violations.length).toEqual(0);

so that violations are printed in CI in the output log, instead of "expected 0, returned 1".

@sean-perkins sean-perkins requested a review from a team April 19, 2022 16:58
@github-actions github-actions bot added the package: core @ionic/core package label Apr 19, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple screenshots do not appear to be correct:

  1. core/src/components/picker-internal/test/basic/picker-internal.e2e.ts-snapshots/picker-internal-popover-diff-ios-ltr-webkit-linux.png shows the popover + backdrop, but the selected items are incorrect. (the RTL version is correct. Maybe this test is flaky?)
  2. core/src/components/picker-internal/test/basic/picker-internal.e2e.ts-snapshots/picker-internal-popover-diff-md-ltr-webkit-linux.png shows the backdrop but no popver.

@sean-perkins
Copy link
Contributor Author

Waiting for the present event to be emitted seems to have more consistent results.

Still need to dig into this one on my end:

Not setting the selected value is likely a rendering issue that a higher timeout may resolve, but will see if there's other alternatives first.

Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM other than the two screenshots Liam mentioned.

@sean-perkins sean-perkins merged commit 87f5840 into main Apr 27, 2022
@sean-perkins sean-perkins deleted the FW-1228 branch April 27, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants