-
Notifications
You must be signed in to change notification settings - Fork 13.5k
test(picker-internal): screenshot and a11y (axe) #25150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple screenshots do not appear to be correct:
core/src/components/picker-internal/test/basic/picker-internal.e2e.ts-snapshots/picker-internal-popover-diff-ios-ltr-webkit-linux.png
shows the popover + backdrop, but the selected items are incorrect. (the RTL version is correct. Maybe this test is flaky?)core/src/components/picker-internal/test/basic/picker-internal.e2e.ts-snapshots/picker-internal-popover-diff-md-ltr-webkit-linux.png
shows the backdrop but no popver.
Waiting for the present event to be emitted seems to have more consistent results. Still need to dig into this one on my end: Not setting the selected value is likely a rendering issue that a higher timeout may resolve, but will see if there's other alternatives first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM other than the two screenshots Liam mentioned.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-picker-internal
e2e tests are written with puppeteer.What is the new behavior?
@axe-core/playwright
for a11y testingion-picker-internal
usagesDoes this introduce a breaking change?
Other information
Opted for testing AXE violations with:
instead of:
so that violations are printed in CI in the output log, instead of "expected 0, returned 1".