Skip to content

fix(react): export stable router reference for useIonRouter hook #25000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 18, 2022
Merged

fix(react): export stable router reference for useIonRouter hook #25000

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7dcc1a7
fix(react): export stable router reference for `useIonRouter` hook
babycourageous Mar 25, 2022
3f6f0a9
Merge branch 'main' into bugfix/use-ion-router-stable-export
sean-perkins Oct 24, 2022
994e662
chore: order hook deps
sean-perkins Oct 26, 2022
1e33b69
Merge branch 'main' into bugfix/use-ion-router-stable-export
sean-perkins Oct 26, 2022
abb6961
Merge branch 'main' into bugfix/use-ion-router-stable-export
liamdebeasi Nov 17, 2022
ee7dd4b
Merge branch 'main' into bugfix/use-ion-router-stable-export
sean-perkins Nov 18, 2022
5889083
Merge branch 'main' into bugfix/use-ion-router-stable-export
liamdebeasi Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/react/src/components/IonRouterContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { AnimationBuilder } from '@ionic/core/components';
import React, { useContext } from 'react';
import React, { useContext, useMemo } from 'react';

import { RouteAction, RouterDirection, RouterOptions } from '../models';
import { RouteInfo } from '../models/RouteInfo';
Expand Down Expand Up @@ -39,13 +39,17 @@ export const IonRouterContext = React.createContext<IonRouterContextState>({
*/
export function useIonRouter(): UseIonRouterResult {
const context = useContext(IonRouterContext);
return {
back: context.back,
push: context.push,
goBack: context.back,
canGoBack: context.canGoBack,
routeInfo: context.routeInfo,
};

return useMemo(
() => ({
back: context.back,
push: context.push,
goBack: context.back,
canGoBack: context.canGoBack,
routeInfo: context.routeInfo,
}),
[context.back, context.push, context.canGoBack, context.routeInfo]
);
}

export type UseIonRouterResult = {
Expand Down