fix(datetime): confirm method now uses selected date #24827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When confirming the date using datetime's
confirm()
method, it will use the working parts (visible calendar month) instead of the active parts (selected calendar month). This results in incorrect date values when a user selects a date, navigates next/previous to a different calendar month and uses theconfirm()
API to close/dismiss the datetime overlay.Issue URL: #24823
What is the new behavior?
confirm()
API uses the active parts when setting the current value.confirm()
, unless the user selects a new date inside that month.Does this introduce a breaking change?
Other information