Skip to content

fix(react): adding href prop when routerLink is specified#19481

Merged
elylucas merged 1 commit intomasterfrom
react-fix-href
Sep 27, 2019
Merged

fix(react): adding href prop when routerLink is specified#19481
elylucas merged 1 commit intomasterfrom
react-fix-href

Conversation

@elylucas
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@elylucas elylucas merged commit cb26f73 into master Sep 27, 2019
@brandyscarney brandyscarney deleted the react-fix-href branch September 27, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant