Skip to content

fix(animation): fallback to CSS Animations on older versions of Chrome#19288

Merged
liamdebeasi merged 1 commit intomasterfrom
animation-chrome-old
Sep 10, 2019
Merged

fix(animation): fallback to CSS Animations on older versions of Chrome#19288
liamdebeasi merged 1 commit intomasterfrom
animation-chrome-old

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 6, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19272
Methods like updateTiming and getComputedTiming actually shipped in Chrome 75, not earlier like I had originally thought. For the most part, people should have autoupdating Chrome (and so this shouldn't be an issue), but some either do not have autoupdating enabled or the autoupdating hasn't kicked in yet for whatever reason. As a result, they were running into this issue since older versions of Chrome only had a partial implementation of Web Animations.

What is the new behavior?

  • Improve the feature detection to look for AnimationEffect support, which should cover the rest of the APIs we use.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Sep 6, 2019
@liamdebeasi liamdebeasi merged commit 2d39c07 into master Sep 10, 2019
@liamdebeasi liamdebeasi deleted the animation-chrome-old branch September 10, 2019 15:32
@daem0ndev
Copy link
Contributor

Thx @liamdebeasi you are a beast! 💙

@cgossett
Copy link

Agreed, thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants