fix(animation): fallback to CSS Animations on older versions of Chrome#19288
Merged
liamdebeasi merged 1 commit intomasterfrom Sep 10, 2019
Merged
fix(animation): fallback to CSS Animations on older versions of Chrome#19288liamdebeasi merged 1 commit intomasterfrom
liamdebeasi merged 1 commit intomasterfrom
Conversation
Contributor
|
Thx @liamdebeasi you are a beast! 💙 |
|
Agreed, thank you sir! |
brandyscarney
pushed a commit
that referenced
this pull request
Sep 16, 2019
brandyscarney
pushed a commit
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #19272
Methods like
updateTimingandgetComputedTimingactually shipped in Chrome 75, not earlier like I had originally thought. For the most part, people should have autoupdating Chrome (and so this shouldn't be an issue), but some either do not have autoupdating enabled or the autoupdating hasn't kicked in yet for whatever reason. As a result, they were running into this issue since older versions of Chrome only had a partial implementation of Web Animations.What is the new behavior?
AnimationEffectsupport, which should cover the rest of the APIs we use.Does this introduce a breaking change?
Other information