Skip to content

fix(theming): update components to use the proper colors for themes#18735

Merged
brandyscarney merged 16 commits intomasterfrom
fix-dark-theme
Jul 12, 2019
Merged

fix(theming): update components to use the proper colors for themes#18735
brandyscarney merged 16 commits intomasterfrom
fix-dark-theme

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jul 8, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • [x ] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: references #18713

What is the new behavior?

Components Needing Updates:

  • Toggle (background, handle)
  • Range (knob, bar)
  • Checkbox (border color)
  • Chip (background, text)
  • Alert (background)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Few the following test to see the dark theme: http://localhost:3334/src/themes/test/css-variables?ionic:mode=ios

master fix-dark-theme
dark theme ios on master dark theme ios on branch
dark theme md on branch dark theme md on master

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jul 8, 2019
@brandyscarney brandyscarney mentioned this pull request Jul 8, 2019
@brandyscarney brandyscarney merged commit 045bc59 into master Jul 12, 2019
@brandyscarney brandyscarney deleted the fix-dark-theme branch September 27, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant