Skip to content

feat(fab-button): add hover state using tint colors#18536

Merged
brandyscarney merged 11 commits intomasterfrom
fix-fab-button-hover
Jun 25, 2019
Merged

feat(fab-button): add hover state using tint colors#18536
brandyscarney merged 11 commits intomasterfrom
fix-fab-button-hover

Conversation

@brandyscarney
Copy link
Member

⚠️ Make sure when this gets merged it gets changed to feat, I accidentally put it as a fix ⚠️

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: references #17624

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jun 13, 2019
@brandyscarney
Copy link
Member Author

TODO I think I broke translucent that Liam mentioned, look into this

also adds a check for backdrop filter support before applying the translucent backdrop filter
@brandyscarney brandyscarney merged commit ad00679 into master Jun 25, 2019
@brandyscarney brandyscarney deleted the fix-fab-button-hover branch June 25, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants