feat: swipe to close modal from content

[nielsdewulf]

Feature Request

Ionic version:

[x] 5.3.2

Describe the Feature Request

Expose swipe back gesture for customization at https://github.com/ionic-team/ionic-framework/blob/master/core/src/components/modal/modal.tsx#L29 . I wish to change the canStart function to disable the gesture when scrolling still needs to happen in the ion-content. If its scrolled to the top, the gesture can happen.

Describe Preferred Solution

Allow to give a custom createSwipeToCloseGesture to the Modal.

Describe Alternatives

Allow to change the individual gesture functions in the already made swipeToCloseGesture

Related Code

Additional Context

[liamdebeasi]

Thanks for the feature request. Can you please describe your use case for this feature?

[nielsdewulf]

Hi @liamdebeasi, I want to create a custom SwipeToCloseGesture. The issue persists when you have scrollable content inside the modal and you use the gesture. It doesn't work since the canStart function inside the gesture returns false when the target is ion-content. I wish to override the canStart function so that I can check if the scrollable content is scrolled to the top. If that's the case I want to allow the gesture so that the modal can be swiped away.

Hope this clarifies my situation a bit more.

[liamdebeasi]

From what it sounds like, you want to be able to swipe to close the modal from the content only if the content is scrolled to the top?

[nielsdewulf]

Yes, which incidentally requires me to customize the swipe to close gesture.

[liamdebeasi]

Thanks - that use case makes sense. There is an open PR that adds this functionality: #21227. There are still some issues with it, so I may work on it myself. I think I would rather add this than expose the entire gesture though.