Skip to content

docs(angular): show complete code context in the "Your First App" tutorial #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

soundproofboot
Copy link
Contributor

@soundproofboot soundproofboot commented Jun 17, 2025

resolves #2082

Changes

  • Update code blocks in first 5 pages of Angular Photo App tutorial to show additional context for each step with comments to indicate new lines.
  • Small changes to surrounding text for clarity.
  • Notes added linking to Angular documentation, localStorage and IndexedDB.

Preview

@soundproofboot soundproofboot requested a review from a team as a code owner June 17, 2025 18:22
@soundproofboot soundproofboot requested a review from gnbm June 17, 2025 18:22
Copy link

vercel bot commented Jun 17, 2025

@soundproofboot is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 2:29pm

@brandyscarney brandyscarney changed the title docs(angular): "Your First App" tutorial should show complete code context(#2082) docs(angular): show complete code context in the "Your First App" tutorial Jun 23, 2025
@brandyscarney brandyscarney requested review from thetaPC and removed request for gnbm June 23, 2025 15:28
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update Page 7 Live reload to include more complete code.

soundproofboot and others added 15 commits June 26, 2025 09:19
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Copy link

vercel bot commented Jun 26, 2025

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

soundproofboot and others added 14 commits June 26, 2025 09:38
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Add context in two previous two code blocks in separate commit.

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@soundproofboot
Copy link
Contributor Author

We should also update Page 7 Live reload to include more complete code.

I'm working on updates to Page 7. Thank you for all the feedback. I'll keep Page 7 changes in line with the rest.

@soundproofboot
Copy link
Contributor Author

@thetaPC I made changes to Page 7 Live Reload in this commit a180cad

@soundproofboot soundproofboot requested a review from thetaPC June 26, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Your First App" tutorial should show complete code context - Angular
2 participants