Skip to content

docs(popover): add nested playground #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2022
Merged

Conversation

averyjohnston
Copy link
Contributor

Adds the Nested Popovers playground. dismissOnSelect was folded in here rather than having its own separate playground, since separating the two felt redundant.

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview May 24, 2022 at 3:04PM (UTC)

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking "More options..." does not dismiss the popover on the JavaScript and Angular StackBlitz demos but does dismiss the popover on the Vue and React demos

@averyjohnston
Copy link
Contributor Author

Looks to be an Ionic bug 🤔 I'll investigate a little and get an issue posted.

@averyjohnston
Copy link
Contributor Author

Done: ionic-team/ionic-framework#25324

@averyjohnston averyjohnston requested a review from liamdebeasi May 20, 2022 14:22
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the reported bug, everything else looks good to me 👍

@averyjohnston averyjohnston merged commit a4181eb into FW-1277-presenting May 24, 2022
@averyjohnston averyjohnston deleted the FW-1277-nested branch May 24, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants