feat(): add standalone as an option #5005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Apr 28, 2023
Comment on lines
+304
to
+309
| name: 'my-first-app', | ||
| projectType: ANGULAR_STANDALONE, | ||
| type: 'repo', | ||
| description: 'A template for the "Build Your First App" tutorial', | ||
| repo: 'https://github.com/ionic-team/photo-gallery-capacitor-ng', | ||
| }, |
There was a problem hiding this comment.
Note: This project does not ship with standalone components, but I added it so we don't get an error on build
sean-perkins
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an option to the Ionic CLI to create an Angular app with either NgModules or Standalone. Developers will be prompted to choose one and will receive the appropriate starter based on their selection.
Related: ionic-team/starters#1773
The NgModules option will pull the
angularstarter app (named this way for backwards compatibility with older versions of the CLI). The Standalone option will pull theangular-standalonestarter app.I split out the standalone support into its own project type since that is what we did for the Vite starters.