Skip to content

chore(doctor): deprecate ionic doctor command #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 12, 2022
Merged

chore(doctor): deprecate ionic doctor command #4907

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
345951a
chore(doctor): deprecate ionic doctor command
liamdebeasi Sep 8, 2022
c3a1f0f
Merge branch 'develop' into deprecate-doctor
liamdebeasi Sep 8, 2022
cb0eea6
chore(): fix format
liamdebeasi Sep 8, 2022
60e23ad
chore(): move log
liamdebeasi Sep 8, 2022
01c28bc
Merge branch 'develop' into deprecate-doctor
liamdebeasi Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@ionic/cli/src/commands/doctor/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ export abstract class DoctorCommand extends Command {
const tasks = this.createTaskChain();
const isLoggedIn = this.env.session.isLoggedIn();

this.env.log.warn(`The ${input('ionic doctor')} command has been deprecated and will be removed in an upcoming major release of the Ionic CLI. Developers can safely remove any references to this command as many of the checks are no longer needed.`);

if (!isLoggedIn) {
this.env.log.warn(`For best results, please make sure you're logged in to Ionic.\nSome issues can't be detected without authentication. Run:\n\n ${input('ionic login')}`);
}
Expand Down