Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@ionic/cli/src/lib/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ export class BuildCLIProgramNotFoundException extends BaseException {}

export class ServeCLIProgramNotFoundException extends BaseException {}

export class DirectoryNotAccessibleException extends FatalException {}

export class SessionException extends BaseException {}

export class RunnerException extends BaseException {}
Expand Down
27 changes: 22 additions & 5 deletions packages/@ionic/cli/src/lib/project/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { BaseConfig, BaseConfigOptions, PackageJson, ParsedArgs } from '@ionic/c
import { PromptModule } from '@ionic/cli-framework-prompts';
import { resolveValue } from '@ionic/cli-framework/utils/fn';
import { ERROR_INVALID_PACKAGE_JSON, compileNodeModulesPaths, isValidPackageName, readPackageJsonFile } from '@ionic/cli-framework/utils/node';
import { ensureDir, findBaseDirectory, readFile, writeFile, writeJson } from '@ionic/utils-fs';
import { ensureDir, findBaseDirectory, pathExistsSync, readFile, writeFile, writeJson } from '@ionic/utils-fs';
import { TTY_WIDTH, prettyPath, wordWrap } from '@ionic/utils-terminal';
import * as Debug from 'debug';
import * as lodash from 'lodash';
Expand All @@ -12,7 +12,7 @@ import { PROJECT_FILE, PROJECT_TYPES } from '../../constants';
import { IAilmentRegistry, IClient, IConfig, IIntegration, ILogger, IMultiProjectConfig, IProject, IProjectConfig, ISession, IShell, InfoItem, IntegrationName, IonicContext, IonicEnvironmentFlags, ProjectIntegration, ProjectPersonalizationDetails, ProjectType } from '../../definitions';
import { isMultiProjectConfig, isProjectConfig } from '../../guards';
import { ancillary, failure, input, strong } from '../color';
import { BaseException, FatalException, IntegrationNotFoundException, RunnerNotFoundException } from '../errors';
import { BaseException, DirectoryNotAccessibleException, FatalException, IntegrationNotFoundException, RunnerNotFoundException } from '../errors';
import { BaseIntegration } from '../integrations';
import { CAPACITOR_CONFIG_FILE, CapacitorConfig } from '../integrations/capacitor/config';
import { Color } from '../utils/color';
Expand Down Expand Up @@ -420,7 +420,10 @@ export abstract class Project implements IProject {
readonly details: ProjectDetailsResult,
protected readonly e: ProjectDeps
) {
this.rootDirectory = path.dirname(details.configPath);
this.rootDirectory = path.dirname(details.configPath);
if (!pathExistsSync(this.rootDirectory)) {
throw new DirectoryNotAccessibleException(`Path ${input(this.rootDirectory)} is not aschessible.`);
}
}

get filePath(): string {
Expand All @@ -434,7 +437,13 @@ export abstract class Project implements IProject {
return this.rootDirectory;
}

return path.resolve(this.rootDirectory, root);
const resolvedPath = path.resolve(this.rootDirectory, root);

if (!pathExistsSync(resolvedPath)) {
throw new DirectoryNotAccessibleException(`Project root ${input(resolvedPath)} is not accessible.`);
}

return resolvedPath;
}

get pathPrefix(): string[] {
Expand Down Expand Up @@ -733,9 +742,17 @@ export abstract class Project implements IProject {
const integration = this.config.get('integrations')[name];

if (integration) {
let rootDirectory = this.directory;

if (integration.root) {
rootDirectory = path.resolve(this.rootDirectory, integration.root);
if (!pathExistsSync(rootDirectory)) {
throw new DirectoryNotAccessibleException(`Integration root ${input(rootDirectory)} is not accessible.`);
}
}
return {
enabled: integration.enabled !== false,
root: integration.root === undefined ? this.directory : path.resolve(this.rootDirectory, integration.root),
root: rootDirectory,
};
}
}
Expand Down