Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Get the proxy from a single function inside Utils instead of repeating code everywhere #124

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Get the proxy from a single function inside Utils instead of repeating code everywhere #124

merged 2 commits into from
Oct 18, 2016

Conversation

icyflame
Copy link
Contributor

@icyflame icyflame commented Oct 7, 2016 •
edited
Loading

  • Added a single test for Utils.getProxy
  • Please tell me how to spoof the environment variable from inside the spec, so that I can write the other test where the function returns a valid proxy

Fixes #122

@icyflame
Copy link
Contributor Author

icyflame commented Oct 7, 2016

The failure of this test is because the test has been run from icyflame/ionic-app-lib, and this repository does not have a coveralls.io account.

@icyflame
Copy link
Contributor Author

ping @jthoms1 and @tlancina Hey! Can you please have a look at this patch? 🙂

@jthoms1 jthoms1 merged commit bf421d4 into ionic-team:master Oct 18, 2016
@icyflame icyflame deleted the fix-http-proxy-line branch October 18, 2016 19:02
@icyflame icyflame mentioned this pull request Oct 18, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icyflame @jthoms1