Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Problem calling Serve.stopServer after Serve.start for automated tests - #113 #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions lib/serve.js
Original file line number Diff line number Diff line change
Expand Up @@ -490,14 +490,18 @@ Serve.startServer = function startServer(options, app) {


// Listen
var q = Q.defer();
app.use(server);
try {
runningServer = app.listen(options.port, options.address);
runningServer = app.listen(options.port, options.address,function(){
logging.logger.info('Running dev server: '.green.bold, options.devServer);
q.resolve()
});
}catch(ex) {
Utils.fail('Failed to start the Ionic server: ', ex.message);
q.reject(Utils.fail('Failed to start the Ionic server: ', ex.message));
}

logging.logger.info('Running dev server: '.green.bold, options.devServer);
return q.promise;
};

Serve.start = function start(options) {
Expand Down Expand Up @@ -990,11 +994,17 @@ Serve.host = function host(address, port) {


Serve.stopServer = function stopServer() {
if (runningServer) {
if(!runningServer && !lrServer){
logging.logger.info('Server not running');
return;
}

if(runningServer){
runningServer.close();
}
if(lrServer){
lrServer.close();
logging.logger.info('Server closed');
} else {
logging.logger.info('Server not running');
}

logging.logger.info('Server closed');
}