fix: expected the module specifier to be a string literal #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
reviewed
Dec 8, 2023
packages/cli/src/angular/migrations/standalone/0004-migrate-import-statements.ts
Outdated
Show resolved
Hide resolved
|
Be great to get this merged if you're happy with the changes. |
|
Hey @luke-rogers ! Apologies this has been delayed. I'll get this rebased and into the v0.2.0 release today. |
sean-perkins
force-pushed
the
fix/module-specifier-string-literal
branch
from
1b5699d to
dd0a74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32
For some reason
project.getSourceFiles()was returning html files causingsourceFile.getImportDeclarations();to fall over. I've also included printing the stack trace rather than just the error message to give the errors slightly more clarity.