-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spm): add product lines to Package.swift #7278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails to detect deleted plugins, they are kept in the Package.swift
file, making the app fail.
I think we should go with full file generation (or at least everything after the // DO NOT MODIFY THIS FILE
) instead of appending the plugins to the existing ones, this way it will generate the file without the uninstalled plugins, otherwise we would need to keep track of installed plugins on every sync and compare with the previous list and update the list, etc.
another idea is to keep the file as is and append the dependencies to the end, I've tried this and it works:
|
Thanks for the bug callout - generating the whole thing from the start might be the answer, or something programmatic. |
@jcesarmobile and now I'm just generating it - hopefully that'll work better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few formatting issues on the resulting file
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Currently in draft as this fixes one problem but is dependent on the following