[Bug]: add serial dispatch queue for storedCalls to avoid data-race (…

…#7480)

Co-authored-by: Mark Anderson <mark@ionic.io>

ios/Capacitor/Capacitor/CapacitorBridge.swift

@@ -113,7 +113,7 @@ open class CapacitorBridge: NSObject, CAPBridgeProtocol {
     // Manager for getting Cordova plugins
     var cordovaPluginManager: CDVPluginManager?
     // Calls we are storing to resolve later
-    var storedCalls = [String: CAPPluginCall]()
+    var storedCalls = ConcurrentDictionary<CAPPluginCall>()
     // Whether to inject the Cordova files
     private var injectCordovaFiles = false
     private var cordovaParser: CDVConfigParser?
@@ -276,7 +276,7 @@ open class CapacitorBridge: NSObject, CAPBridgeProtocol {
      sending data back to the page from a previous page.
      */
     func reset() {
-        storedCalls = [String: CAPPluginCall]()
+        storedCalls.withLock { $0.removeAll() }
     }
 
     /**
@@ -386,7 +386,7 @@ open class CapacitorBridge: NSObject, CAPBridgeProtocol {
     }
 
     @objc public func releaseCall(withID: String) {
-        storedCalls.removeValue(forKey: withID)
+        let _ = storedCalls.withLock { $0.removeValue(forKey: withID) }
     }
 
     // MARK: - Deprecated Versions

ios/Capacitor/Capacitor/KeyValueStore.swift

@@ -272,11 +272,12 @@ private class InMemoryStore: KeyValueStoreBackend {
     }
 }
 
-private class ConcurrentDictionary<Value> {
-    private var storage: [String: Value]
+class ConcurrentDictionary<Value> {
+    typealias StorageType = [String: Value]
+    private var storage: StorageType
     private let lock = NSLock()
 
-    init(_ initial: [String: Value] = [:]) {
+    init(_ initial: StorageType = [:]) {
         storage = initial
     }
 
@@ -293,4 +294,10 @@ private class ConcurrentDictionary<Value> {
             }
         }
     }
+
+    func withLock<T>(_ body: (_ storage: inout StorageType) -> T) -> T {
+        lock.withLock {
+            body(&storage)
+        }
+    }
 }