feat(browser): implement close() method for android #1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsChaceD
requested review from
markemer,
jcesarmobile,
theproducer,
IT-MikeS and
giralte-ionic
|
Released dev build of browser with dev version: 6.0.0-dev-1972-20240122T161017.0 |
giralte-ionic
approved these changes
Dec 21, 2023
markemer
reviewed
Jan 10, 2024
browser/android/src/main/java/com/capacitorjs/plugins/browser/BrowserPlugin.java
Outdated
Show resolved
Hide resolved
|
This looks ok to me, but I'm going to wait on @theproducer's call on his group of real devices before I sign off. |
theproducer
reviewed
Jan 22, 2024
browser/android/src/main/java/com/capacitorjs/plugins/browser/BrowserPlugin.java
Outdated
Show resolved
Hide resolved
theproducer
approved these changes
Jan 22, 2024
bentleyo
added a commit
to bentleyo/capacitor-plugins
that referenced
this pull request
Sep 19, 2024
This was referenced Sep 19, 2024
bentleyo
added a commit
to bentleyo/capacitor-plugins
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
This PR adds the
close()method to the Android Browser Plugin.We create an "intermediate" controller activity that launches the custom tabs, and when we want to close, we launch the same activity with
FLAG_ACTIVITY_CLEAR_TOPwhich triggersonNewIntentwhere we can detect to destroy the activity & custom tabs, without sacrificing the existing activity stack.