Skip to content

Commit

Permalink
chore(lint): null keyword config
Browse files Browse the repository at this point in the history
  • Loading branch information
imhoffd committed Jan 24, 2019
1 parent b614db9 commit 6c7ca09
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion builders/cordova-build/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class CordovaBuildBuilder implements Builder<CordovaBuildBuilderSchema> {
let browserConfig = this.context.architect.getBuilderConfiguration<BrowserBuilderSchema>(browserTargetSpec);
let browserDescription: BuilderDescription;

return of(null).pipe(// tslint:disable-line:no-null-keyword
return of(null).pipe(
concatMap(() => this.context.architect.getBuilderDescription(browserConfig)),
tap(description => browserDescription = description),
concatMap(() => this.context.architect.validateBuilderOptions(browserConfig, browserDescription)),
Expand Down
4 changes: 2 additions & 2 deletions builders/cordova-serve/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { BuildEvent, Builder, BuilderConfiguration, BuilderContext, BuilderDescr
import { BrowserBuilderSchema } from '@angular-devkit/build-angular/src/browser/schema';
import { DevServerBuilder, DevServerBuilderOptions } from '@angular-devkit/build-angular/src/dev-server';
import { Path, virtualFs } from '@angular-devkit/core';
import * as ζfs from 'fs';
import * as fs from 'fs';
import { Observable, of } from 'rxjs';
import { concatMap, tap } from 'rxjs/operators';

Expand Down Expand Up @@ -51,7 +51,7 @@ class CordovaDevServerBuilder extends DevServerBuilder {
super(context);
}

buildWebpackConfig(root: Path, projectRoot: Path, host: virtualFs.Host<ζfs.Stats>, browserOptions: BrowserBuilderSchema) {
buildWebpackConfig(root: Path, projectRoot: Path, host: virtualFs.Host<fs.Stats>, browserOptions: BrowserBuilderSchema) {
const builder = new CordovaBuildBuilder(this.context);
builder.prepareBrowserConfig(this.cordovaBuildOptions, browserOptions);

Expand Down
3 changes: 2 additions & 1 deletion tslint.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"extends": "tslint-ionic-rules/strict",
"rules": {
"strict-boolean-conditions": false
"strict-boolean-conditions": false,
"no-null-keyword": false
}
}

0 comments on commit 6c7ca09

Please sign in to comment.