Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #182

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/test-and-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,15 @@ jobs:
if: contains(github.event.head_commit.message, '[skip ci]') == false

runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x]

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: 18.x

- name: Install dependencies
run: npm ci
Expand All @@ -51,7 +48,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [18.x, 20.x]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand All @@ -72,7 +69,7 @@ jobs:
if: startsWith(runner.OS, 'windows')
run: set DEBUG=testing:* & npm run test:integration

# Deploys the final package to NPM and Github Actions
# Deploys the final package to NPM and GitHub Actions
deploy:
# Trigger this step only when a commit on master is tagged with a version number
if: |
Expand Down Expand Up @@ -123,7 +120,7 @@ jobs:
tag_name: ${{ github.ref }}
release_name: Release v${{ steps.extract_release.outputs.VERSION }}
draft: false
# Prerelease versions create prereleases on Github
# Prerelease versions create pre-releases on GitHub
prerelease: ${{ contains(steps.extract_release.outputs.VERSION, '-') }}
body: ${{ steps.extract_release.outputs.BODY }}

Expand All @@ -137,7 +134,7 @@ jobs:
sentry-cli releases new $SENTRY_VERSION
sentry-cli releases finalize $SENTRY_VERSION

# Dummy job for skipped builds - without this, github reports the build as failed
# Dummy job for skipped builds - without this, GitHub reports the build as failed
skip-ci:
if: contains(github.event.head_commit.message, '[skip ci]')
runs-on: ubuntu-latest
Expand Down
37 changes: 0 additions & 37 deletions .npmignore

This file was deleted.

28 changes: 0 additions & 28 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2020-2022 Peter Baumert
Copyright (c) 2020-2023 Peter Baumert

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
23 changes: 14 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,26 @@ Implements same technique as https://speedtest.vodafone.de
## What is Sentry.io and what is reported to the servers of that company?
Sentry.io is a service for developers to get an overview about errors from their applications. And exactly this is implemented in this adapter.

When the adapter crashes or an other Code error happens, this error message that also appears in the ioBroker log is submitted to Sentry. When you allowed iobroker GmbH to collect diagnostic data then also your installation ID (this is just a unique ID **without** any additional infos about you, email, name or such) is included. This allows Sentry to group errors and show how many unique users are affected by such an error. All of this helps me to provide error free adapters that basically never crashs.
When the adapter crashes or another Code error happens, this error message that also appears in the ioBroker log is submitted to Sentry.
When you allowed to ioBroker GmbH to collect diagnostic data, then also your installation ID (this is just a unique ID **without** any additional infos about you, email, name or such) is included.
This allows Sentry to group errors and shows how many unique users are affected by such an error. All of this helps me to provide error-free adapters that basically never crash.

## Changelog
<!--
Placeholder for the next version (at the beginning of the line):
### **WORK IN PROGRESS**
-->
### 1.0.1 (2023-09-13)
* (bluefox) Updated packages and refactored code

### 1.0.0 (2023-09-13)
* (bluefox) Updated packages and refactored code

### 0.0.13 (2022-06-06)
* some more "already running" fixes

### 0.0.12 (2022-05-28)
* rerelease for 0.0.11 because of missing version in io-package.json
* re-release for 0.0.11 because of a missing version in io-package.json

### 0.0.11 (2022-05-27)
* updating dependencies
Expand Down Expand Up @@ -63,11 +71,11 @@ When the adapter crashes or an other Code error happens, this error message that
* Added calculated values by actual raw data

### 0.0.4 (2020-04-30)
* Changed Adapter start type to scheduled (reinstallation might be needed)
* Changed Adapter start type to scheduled (re-installation might be needed)
* Bug fixes and feedback implementation

### 0.0.3 (2020-04-24)
* Implemented feedback from Forum and github issue
* Implemented feedback from Forum and GitHub issue

### 0.0.2 (2020-04-19)
* Added actual settings in Admin interface
Expand All @@ -82,7 +90,7 @@ Vodafone is a trademark of Vodafone GmbH. I am in no way endorsed by or affiliat
## License
MIT License

Copyright (c) 2020-2022 Peter Baumert
Copyright (c) 2020-2023 Peter Baumert

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -100,7 +108,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.


[pr112]: https://github.com/peterbaumert/ioBroker.vofo-speedtest/pull/112
SOFTWARE.
5 changes: 5 additions & 0 deletions admin/i18n/de/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Lokale Adresse",
"Use curl": "CURL verwenden ",
"for download too (for some better performance)": "Auch zum Herunterladen (für eine bessere Leistung)"
}
5 changes: 5 additions & 0 deletions admin/i18n/en/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Local address",
"Use curl": "Use CURL",
"for download too (for some better performance)": "for download too (for some better performance)"
}
5 changes: 5 additions & 0 deletions admin/i18n/es/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Dirección local",
"Use curl": "Usar el CURL",
"for download too (for some better performance)": "para descargar también (para un mejor rendimiento)"
}
5 changes: 5 additions & 0 deletions admin/i18n/fr/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Adresse locale",
"Use curl": "Utiliser la CURL",
"for download too (for some better performance)": "pour le téléchargement également (pour de meilleures performances)"
}
5 changes: 5 additions & 0 deletions admin/i18n/it/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Indirizzo locale",
"Use curl": "Utilizza il CURL",
"for download too (for some better performance)": "anche per il download (per prestazioni migliori)"
}
5 changes: 5 additions & 0 deletions admin/i18n/nl/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Lokaal adres",
"Use curl": "Gebruik de CURL",
"for download too (for some better performance)": "Ook om te downloaden (voor betere prestaties)"
}
5 changes: 5 additions & 0 deletions admin/i18n/pl/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Lokalny adres",
"Use curl": "Użyj CURL",
"for download too (for some better performance)": "również do pobrania (dla lepszej wydajności)"
}
5 changes: 5 additions & 0 deletions admin/i18n/pt/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Endereço local",
"Use curl": "Usar o CURL",
"for download too (for some better performance)": "para download também (para um melhor desempenho)"
}
5 changes: 5 additions & 0 deletions admin/i18n/ru/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Местный адрес",
"Use curl": "Использовать CURL",
"for download too (for some better performance)": "для загрузки тоже (для лучшей производительности)"
}
5 changes: 5 additions & 0 deletions admin/i18n/uk/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "Місцева адреса",
"Use curl": "Використовуйте CURL",
"for download too (for some better performance)": "також для завантаження (для кращої продуктивності)"
}
5 changes: 5 additions & 0 deletions admin/i18n/zh-cn/translations.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Local address": "本地地址",
"Use curl": "使用CURL命令",
"for download too (for some better performance)": "也可供下载(以获得更好的性能)"
}
23 changes: 23 additions & 0 deletions admin/jsonConfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"i18n": true,
"type": "panel",
"items": {
"bindAddress": {
"type": "ip",
"label": "Local address",
"default": "0.0.0.0",
"sm": 12,
"md": 6,
"lg": 4
},
"useCurl": {
"newLine": true,
"type": "checkbox",
"help": "for download too (for some better performance)",
"label": "Use curl",
"sm": 12,
"md": 6,
"lg": 4
}
}
}
Loading