remove typescript peer dependency #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add changelog placeholder? |
foxriver76
approved these changes
Mar 9, 2025
Closed
mcm1957
changed the title
|
README.md changelog added into this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes peerDependency for typescript
Requiring typescript to be ~5.8.0 blocks installation of eslint-config@2.0.0 as log as an older typescript version is installed. Otherwise updating typescript to 5.8.x is not possible as long as eslint-confi@1.x.x is installed - at least not without ignoring errors.
Until 2.0.0 typescript was not listed as peerDependency. I do not see a reason to request / check this as eslint typeScript plugin(s) anyway check the supported typescript version. And eslint-config itself does not use tyoescript or an special feature of it.
So eslint-config should not require a specific typescript version to allow a smooth installtion.