Skip to content

new addon for italian scontrino #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 10, 2025
Merged

new addon for italian scontrino #460

merged 20 commits into from
Mar 10, 2025

Conversation

alvarolivie
Copy link
Contributor

@alvarolivie alvarolivie commented Feb 17, 2025

The adecf addon is currently based on information from the AdE.
As no official Italian framework for uploading this type of document is yet in place, this addon must be treated as a work in progress. We cannot be sure that the format that the Italian government require will not change.

Cannot check for nil supplier or nil tax as GOBL will reject the invoice before it reaches this addon's validation.

Pre-Review Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents to show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes, either structured or in the comments.
  • I've run go generate . to ensure that the Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

@alvarolivie alvarolivie self-assigned this Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 90.97744% with 12 lines in your changes missing coverage. Please review.

Project coverage is 87.41%. Comparing base (2015886) to head (b70ab84).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
addons/it/ticket/invoices.go 88.00% 4 Missing and 2 partials ⚠️
addons/it/ticket/tax.go 81.81% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   87.38%   87.41%   +0.03%     
==========================================
  Files         264      268       +4     
  Lines       13628    13759     +131     
==========================================
+ Hits        11909    12028     +119     
- Misses       1373     1381       +8     
- Partials      346      350       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alvarolivie alvarolivie marked this pull request as ready for review February 25, 2025 12:19
@alvarolivie alvarolivie requested a review from samlown February 25, 2025 12:19
Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Almost there. A few minor suggestions. For sure we should rename.

Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good 👍 nice!

@alvarolivie alvarolivie merged commit b031bbb into main Mar 10, 2025
5 checks passed
@alvarolivie alvarolivie deleted the it-scontrino branch March 10, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants