-
Notifications
You must be signed in to change notification settings - Fork 14
new addon for italian scontrino #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 87.38% 87.41% +0.03%
==========================================
Files 264 268 +4
Lines 13628 13759 +131
==========================================
+ Hits 11909 12028 +119
- Misses 1373 1381 +8
- Partials 346 350 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Almost there. A few minor suggestions. For sure we should rename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good 👍 nice!
The adecf addon is currently based on information from the AdE.
As no official Italian framework for uploading this type of document is yet in place, this addon must be treated as a work in progress. We cannot be sure that the format that the Italian government require will not change.
Cannot check for nil supplier or nil tax as GOBL will reject the invoice before it reaches this addon's validation.
Pre-Review Checklist
go generate .
to ensure that the Schemas and Regime data are up to date.