-
Notifications
You must be signed in to change notification settings - Fork 14
Payment receipts and advances in Portugal #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
+ Coverage 85.67% 85.92% +0.24%
==========================================
Files 255 257 +2
Lines 12582 12803 +221
==========================================
+ Hits 10780 11001 +221
Misses 1454 1454
Partials 348 348 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! I do think we should start moving all the documentation to the structure approach though. My objective is to remove README.md files completely, as everything should be defined inside the Go structures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can be a bit more efficient perhaps with the tables, but otherwise, this looks great! Juan will be happy too :-)
one
in PTbill.Receipt
without linesbill.Receipt
to allow empty codes while the invoice isn't signed (like inbill.Invoice
)bill.Receipt
Pre-Review Checklist
go generate .
to ensure that the Schemas and Regime data are up to date.