-
Notifications
You must be signed in to change notification settings - Fork 14
Complete PT regime and SAF-T addon #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 84.57% 85.08% +0.51%
==========================================
Files 250 254 +4
Lines 12348 12518 +170
==========================================
+ Hits 10443 10651 +208
+ Misses 1553 1518 -35
+ Partials 352 349 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really nice! I've added a few suggestions that are worth discussing before merge.
BTW, I'd also aim for 100% test coverage if possible. I've been forcing myself recently, and feeling happier about it :-) |
I also like large coverage as it often reveals issues you didn't anticipate. However, taken to the extreme, it forces to test certain logic in private functions that is there only as mere safeguards (cases that must not happen). I'm not always sure the effort of covering those cases is worth it. But I'll see if I can get to 100% here. |
100% coverage achieved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔝 🎩
This PR completes the PT regime and the SAF-T by adding:
Part of APP-101
Pre-Review Checklist
go generate .
to ensure that the Schemas and Regime data are up to date.