Skip to content

Switch to patchmatch-cython from pypatchmatch due to default availability on more platforms #8788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aleyan wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Switch to patchmatch-cython from pypatchmatch due to default availability on more platforms #8788

aleyan wants to merge 7 commits into from

Conversation

@aleyan
Copy link
Contributor

@aleyan aleyan commented Jan 26, 2026 •
edited
Loading

Summary

pypatchmatch has a dependency on OpenCV, which is tricky to install and/or compile on many platforms. This replaces it for another patchmatch implementation with cython wheels prebuilt for most common platforms.

Related Issues / Discussions

Closes #8781

QA Instructions

Saw "patchmatch" option appear in canvas Compositing/Infill. Generates infill.

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files Root backend PRs that change backend files python-deps PRs that change python dependencies labels Jan 26, 2026
@aleyan aleyan changed the title Switch to patchmatch-cython from py patchmatch due to default availability on more platforms Switch to patchmatch-cython from pypatchmatch due to default availability on more platforms Jan 26, 2026
@iwr-redmond
Copy link

iwr-redmond commented Jan 26, 2026

The Dockerfiles for CUDA and ROCm will also need to be updated.

@aleyan
Copy link
Contributor Author

aleyan commented Jan 26, 2026

The Dockerfiles for CUDA and ROCm will also need to be updated.

Removed building of patchmatch in Dockerfiles. Kept the installing of libopencv-dev, but it is not clear to me if opencv bindings are needed anymore.

@iwr-redmond
Copy link

iwr-redmond commented Jan 26, 2026 •
edited
Loading

OpenCV is still recommended for patchmatch-cython and is required for invisible-watermark.

See also: launcher#81

@aleyan
Copy link
Contributor Author

aleyan commented Jan 27, 2026

OpenCV is still recommended for patchmatch-cython and is required for invisible-watermark.

See also: launcher#81

Ok, based on that, I will keep the opencv bindings in the Dockerfiles.

Are any other changes required?

@lstein lstein added the v6.12.0 Intended for 6.12.0 release label Jan 29, 2026
@lstein lstein moved this from 6.12.x to 6.13.x in Invoke - Community Roadmap Jan 30, 2026
@lstein lstein added v6.13.x and removed v6.12.0 Intended for 6.12.0 release labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@dunkeroni dunkeroni Awaiting requested review from dunkeroni dunkeroni is a code owner

@JPPhoto JPPhoto Awaiting requested review from JPPhoto JPPhoto is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dunkeroni dunkeroni

Labels

backend PRs that change backend files docker python PRs that change python files python-deps PRs that change python dependencies Root v6.13.x

Projects

Invoke - Community Roadmap
Status: 6.13.x

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[enhancement]: Switch to patchmatch-cython

5 participants

@aleyan @iwr-redmond @lstein @dunkeroni @JPPhoto