fix(ui): control layer transparency effect not working #8496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
changed the title
psychedelicious
force-pushed
the
psyche/fix/ui/konva-caching-2
branch
from
5538fc8 to
e51a4f2
Compare
hipsterusername
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A change in #8493 intended to prevent konva from caching nodes that have no content (preventing errors about caching a node with 0 width or height) inadvertently is breaking the Control Layer transparency effect. There appears to be a bug (?) where konva doesn't reliably calculate the size of object groups which means my fix doesn't reliably do what it was intended to do.
Related Issues / Discussions
Reported on discord
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)