fix(ui): race condition when setting hf token and downloading model #8456
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into a race condition where I set a HF token and it was valid, but somehow this error toast still appeared. The conditional feel through to an assertion that we never expected to get to, which crashed the UI. Handled the unexpected case gracefully now.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran into a race condition where I set a HF token and it was valid, but somehow this error toast still appeared. The conditional feel through to an assertion that we never expected to get to, which crashed the UI.
Handled the unexpected case gracefully now.
Related Issues / Discussions
n/a
QA Instructions
Hard to repro given its a race condition between the HF hub library and our model manager.
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)