fix(ui): float input precision #8455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Aug 22, 2025
psychedelicious
force-pushed
the
psyche/fix/ui/number-input-precision
branch
from
08064a9 to
0aff954
Compare
Determine the "base" step for floats. If no `multipleOf` is provided, the "base" step is `undefined`, meaning the float can have any number of decimal places. The UI library does its own step constrains though and is rounding to 3 decimal places. Probably need to update the logic in the UI library to have truly arbitrary precision for float fields.
psychedelicious
force-pushed
the
psyche/fix/ui/number-input-precision
branch
from
0aff954 to
6dba14f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Determine the "base" step for floats. If no
multipleOfis provided, the "base" step isundefined, meaning the float can have any number of decimal places.The UI library does its own step constrains though and is rounding to 3 decimal places. Probably need to update the logic in the UI library to have truly arbitrary precision for float fields.
Related Issues / Discussions
In #8450 a bug was fixed, the
constrainValueprop wasn't added on float fields when it should have been. Adding it added more constraints to the fields, altering their precision.QA Instructions
float fields should behave like they did before #8450 now
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)