Skip to content

refactor(ui): navigation API #8199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 4, 2025
Merged

refactor(ui): navigation API #8199

merged 9 commits into from
Jul 4, 2025

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Revert to only rendering tabs when they are active (fixes some bad perf issues and other weirdness)
  • Implement new navigation API that handles the async nature of dockview panel initialization
  • Add loading screen when switching between tabs to make it feel less janky

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jul 4, 2025
@psychedelicious psychedelicious force-pushed the psyche/refactor/navigation-api branch from 5f198dd to e40a9e9 Compare July 4, 2025 06:46
@psychedelicious psychedelicious merged commit d94aa4a into main Jul 4, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/refactor/navigation-api branch July 4, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername