Skip to content

Update scaling math to land on 100% consistently. #8043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025

Conversation

hipsterusername
Copy link
Member

Summary

This pull request updates the zooming functionality in the CanvasStageModule to improve user experience by refining the scale factor and introducing snapping to common zoom levels. The changes ensure smoother scaling and better precision when zooming in and out.

Zooming Improvements:

Related Issues / Discussions

Some miscellaneous discord discussions.

QA Instructions

Scroll around on the canvas.

Merge Plan

Should be good to go on review.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label May 25, 2025
@hipsterusername hipsterusername marked this pull request as ready for review May 25, 2025 03:21
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@ufuksarp
Copy link
Contributor

Thank you.

@hipsterusername hipsterusername merged commit 3fd28ce into main May 25, 2025
17 of 23 checks passed
@hipsterusername hipsterusername deleted the fix-scroll-scaling branch May 25, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants