fix(ui): always add selectModelsTab hotkey data to prevent unhandled exception while registering the hotkey handler #7981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
changed the title
…exception while registering the hotkey handler
This will both hide the hotkey from the hotkey modal and override any other enabled status it has.
psychedelicious
force-pushed
the
psyche/fix/ui/mm-hotkey
branch
from
076d640 to
89bf2b7
Compare
maryhipp
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the
modelManagerapp feature is disabled, the hotkey data to switch to the model manager tab is never added. Then, when the hotkey handler is defined, because the data wasn't added, there is an error.This PR ensures the hotkey data is always added and adds an additional global override for disabling hotkeys. Only the models tab hotkey uses this right now. The override is set when the
modelManagerfeature is disabled via InvokeAIUI prop.Related Issues / Discussions
n/a
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)