Skip to content

feat(ui): iterate on combobox component, model picker #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 1, 2025
Merged

feat(ui): iterate on combobox component, model picker #7975

merged 6 commits into from
May 1, 2025

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Iterate on combobox/picker component (layout, functionality, perf, flexibility)
  • Port over a good chunk of model dropdowns to it
  • Start moving non-model drop-downs to native select - still a fair few to port
  • Need to get the thing to auto-size correctly

Related Issues / Discussions

n/a

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Apr 30, 2025
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/model-picker-2 branch from 35a2c3b to 455bcb0 Compare May 1, 2025 01:08
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/model-picker-2 branch from bde955d to 30843b3 Compare May 1, 2025 06:15
@psychedelicious psychedelicious merged commit 5e001be into main May 1, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/model-picker-2 branch May 1, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername