feat(ui): add _all_ image outputs to gallery (including collections) #7957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when a node completed, we checked to see if its output was exactly an
ImageOutput
. If so, we add the image to the gallery. But there are multiple types of nodes that output images via some other output class. For example, anImageCollectionOutput
. When a node outputted one of these other classes, the UI wouldn't update the gallery. You'd have to refresh the page to see the image in gallery.With the change in this PR, when a node completes, we check each of its output's properties. If any are an
ImageField
orlist[ImageField]
, they are all added to the gallery. This coversImageOutput
,ImageCollectionOutput
, and all other outputs that have an image.Related Issues / Discussions
@skunkworxdark mentioned on discord: https://discord.com/channels/1020123559063990373/1049495067846524939/1365019122840371262
QA Instructions
Merge Plan
n/a
Checklist
What's New
copy (if doing a release after this PR)